Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use shadow_rs for versions #523

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Dec 11, 2023

Describe your change

Replaces the common::get_version util function with the PKG_VERSION variables extracted from shadow_rs.

If you know of any other opportunities where we can replace things from shadow_rs, we can add them in this PR as wel..

Motivation and context

shadow_rs makes the old function redundant

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Yohe-Am Yohe-Am merged commit 7815dad into main Dec 12, 2023
11 checks passed
@Yohe-Am Yohe-Am deleted the refactor/MET-288/shadow-version branch December 12, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants